Fix NoMethodError in Bugsnag Railtie
#666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen if Bugsnag is added to the Gemfile with 'require: false'. In this case, 'require "bugsnag"' in a Rails initializer will run the 'config.before_initialize' before the rest of the Railtie has been executed. This results in the 'event_subscription' method being undefined as it was declared below the line that calls it By moving it to the top of the file this is no longer a problem
kattrali
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This can happen if Bugsnag is added to the Gemfile with
require: false. In this case,require "bugsnag"in a Rails initializer will run theconfig.before_initializebefore the rest of the class has executed. This results in the 'event_subscription' method being undefined as it is declared below the line that calls itBy moving the method definition to the top of the file, this is no longer a problem
See #653